netbird-dashboard: fix SPA routing by falling back to index.html#500798
Merged
K900 merged 1 commit intoNixOS:masterfrom Mar 23, 2026
Merged
netbird-dashboard: fix SPA routing by falling back to index.html#500798K900 merged 1 commit intoNixOS:masterfrom
K900 merged 1 commit intoNixOS:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The NetBird dashboard is a Single Page Application (SPA). Currently, the
nixos/netbird-dashboardmodule configures Nginx without a fallback toindex.html.Because of this, when users attempt to authenticate using an IDP (like Keycloak or PocketID), the IDP redirects back to the dashboard at routes like
/author/silent-auth. Nginx intercepts these, fails to find a matching file, and returns a 404 instead of letting the SPA handle the routing.This change updates the default Nginx
tryFilesconfiguration to"$uri $uri/ /index.html", which properly routes these requests to the frontend app.I'll run more tests when I can.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.